Commit 13fef095 authored May 17, 2016 by Chen-Yu Tsai Committed by Maxime Ripard May 30, 2016

drm: sun4i: do cleanup if RGB output init fails



sun4i_rgb_init() can fail, which results in TCON failing to bind.
In this case we need to do cleanup, specificly unregistering the
dotclock, which is regmap based, and the regmap is registered as
part of the sun4i_tcon_bind().

Failing to do so results in a NULL pointer reference when the CCF
tries to turn off unused clocks.

Fixes: 29e57fab ("drm: sun4i: Add RGB output")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

parent 7aa2e2b7

drivers/gpu/drm/sun4i/sun4i_tcon.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -490,7 +490,11 @@ static int sun4i_tcon_bind(struct device dev, struct device master,
		return 0;
		}

		return sun4i_rgb_init(drm);
		ret = sun4i_rgb_init(drm);
		if (ret < 0)
		goto err_free_clocks;

		return 0;

		err_free_clocks:
		sun4i_tcon_free_clocks(tcon);