Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 13ba564c authored by Julia Lawall's avatar Julia Lawall Committed by Nicholas Bellinger
Browse files

target: remove unneeded array 

Delete a local array that is only used to be initialized by memset.

A semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier x;
type T;
@@

{
... when any
-T x[...];
<+... when != x
- memset(x,...);
...+>
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 7f2c53bb

drivers/target/target_core_pr.c

+2 −5
Original line number Diff line number Diff line
@@ -1429,14 +1429,12 @@ core_scsi3_decode_spec_i_port( 
	struct target_core_fabric_ops *tmp_tf_ops;

	unsigned char *buf;

	unsigned char *ptr, *i_str = NULL, proto_ident, tmp_proto_ident;

	char *iport_ptr = NULL, dest_iport[64], i_buf[PR_REG_ISID_ID_LEN];

	char *iport_ptr = NULL, i_buf[PR_REG_ISID_ID_LEN];

	sense_reason_t ret;

	u32 tpdl, tid_len = 0;

	int dest_local_nexus;

	u32 dest_rtpi = 0;



	memset(dest_iport, 0, 64);



	local_se_deve = se_sess->se_node_acl->device_list[cmd->orig_fe_lun];

	/*

	 * Allocate a struct pr_transport_id_holder and setup the
@@ -3059,7 +3057,7 @@ core_scsi3_emulate_pro_register_and_move(struct se_cmd *cmd, u64 res_key, 
	struct t10_reservation *pr_tmpl = &dev->t10_pr;

	unsigned char *buf;

	unsigned char *initiator_str;

	char *iport_ptr = NULL, dest_iport[64], i_buf[PR_REG_ISID_ID_LEN];

	char *iport_ptr = NULL, i_buf[PR_REG_ISID_ID_LEN];

	u32 tid_len, tmp_tid_len;

	int new_reg = 0, type, scope, matching_iname;

	sense_reason_t ret;
@@ -3071,7 +3069,6 @@ core_scsi3_emulate_pro_register_and_move(struct se_cmd *cmd, u64 res_key, 
		return TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;

	}



	memset(dest_iport, 0, 64);

	memset(i_buf, 0, PR_REG_ISID_ID_LEN);

	se_tpg = se_sess->se_tpg;

	tf_ops = se_tpg->se_tpg_tfo;