Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1307f214 authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu: Invert sync_rcu_exp_select_cpus() "if" statement 



This commit saves a couple lines of code and reduces indentation
by inverting the sense of an "if" statement in the function
sync_rcu_exp_select_cpus().

Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent 886ef5a1

kernel/rcu/tree.c

+14 −16
Original line number Diff line number Diff line
@@ -3716,25 +3716,23 @@ static void sync_rcu_exp_select_cpus(struct rcu_state *rsp, 
			ret = smp_call_function_single(cpu, func, rsp, 0);

			if (!ret) {

				mask_ofl_ipi &= ~mask;

			} else {

				continue;

			}

			/* Failed, raced with offline. */

			raw_spin_lock_irqsave_rcu_node(rnp, flags);

			if (cpu_online(cpu) &&

			    (rnp->expmask & mask)) {

					raw_spin_unlock_irqrestore(&rnp->lock,

								   flags);

				raw_spin_unlock_irqrestore(&rnp->lock, flags);

				schedule_timeout_uninterruptible(1);

				if (cpu_online(cpu) &&

				    (rnp->expmask & mask))

					goto retry_ipi;

					raw_spin_lock_irqsave_rcu_node(rnp,

								       flags);

				raw_spin_lock_irqsave_rcu_node(rnp, flags);

			}

			if (!(rnp->expmask & mask))

				mask_ofl_ipi &= ~mask;

			raw_spin_unlock_irqrestore(&rnp->lock, flags);

		}

		}

		/* Report quiescent states for those that went offline. */

		mask_ofl_test |= mask_ofl_ipi;

		if (mask_ofl_test)