Commit 130320bf authored Sep 18, 2012 by Peter Senna Tschudin Committed by Florian Tobias Schandinat Sep 22, 2012

drivers/video/atmel_lcdfb.c: fix error return code

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>

parent b157dd1c

drivers/video/atmel_lcdfb.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -931,8 +931,10 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
		}

		info->screen_base = ioremap(info->fix.smem_start, info->fix.smem_len);
		if (!info->screen_base)
		if (!info->screen_base) {
		ret = -ENOMEM;
		goto release_intmem;
		}

		/*
		* Don't clear the framebuffer -- someone may have set
		@@ -960,6 +962,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
		sinfo->mmio = ioremap(info->fix.mmio_start, info->fix.mmio_len);
		if (!sinfo->mmio) {
		dev_err(dev, "cannot map LCDC registers\n");
		ret = -ENOMEM;
		goto release_mem;
		}