Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 12d5a43b authored by tangwenji's avatar tangwenji Committed by Nicholas Bellinger
Browse files

iscsi-target: fix memory leak in lio_target_tiqn_addtpg() 



tpg must free when call core_tpg_register() return fail

Signed-off-by: default avatartangwenji <tang.wenji@zte.com.cn>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 24528f08

drivers/target/iscsi/iscsi_target_configfs.c

+2 −1
Original line number Diff line number Diff line
@@ -1123,7 +1123,7 @@ static struct se_portal_group *lio_target_tiqn_addtpg( 


	ret = core_tpg_register(wwn, &tpg->tpg_se_tpg, SCSI_PROTOCOL_ISCSI);

	if (ret < 0)

		return NULL;

		goto free_out;



	ret = iscsit_tpg_add_portal_group(tiqn, tpg);

	if (ret != 0)
@@ -1135,6 +1135,7 @@ static struct se_portal_group *lio_target_tiqn_addtpg( 
	return &tpg->tpg_se_tpg;

out:

	core_tpg_deregister(&tpg->tpg_se_tpg);

free_out:

	kfree(tpg);

	return NULL;

}