Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 121bdbf1 authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: Remove stack hog issue from TODO 



Since there is no vchiq function listed by "make checkstack" anymore,
we can remove the stack hog issue from the TODO.

Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ae8d5f46

drivers/staging/vc04_services/interface/vchi/TODO

+2 −7
Original line number Diff line number Diff line
@@ -40,17 +40,12 @@ should properly handle a module unload. This also includes that all 
resouces must be freed (kthreads, debugfs entries, ...) and global

variables avoided.



5) Fix stack hog



Running make checkstack shows that vchiq_dump_service_use_state() has

an extensive stack usage. Maybe other functions are also affected.



6) Cleanup logging mechanism

5) Cleanup logging mechanism



The driver should probably be using the standard kernel logging mechanisms

such as dev_info, dev_dbg, and friends.



7) Documentation

6) Documentation



A short top-down description of this driver's architecture (function of

kthreads, userspace, limitations) could be very helpful for reviewers.