Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 11b8dd56 authored by Colin Ian King's avatar Colin Ian King Committed by Alistair Delva
Browse files

UPSTREAM: drm/virtio: fix memory leak of vfpriv on error return path 



The allocation for vfpriv is being leaked on an error return path,
fix this by kfree'ing it before returning.

Detected by CoverityScan, CID#1475380 ("Resource Leak")

Fixes: 6a37c49a94a9 ("drm/virtio: Handle context ID allocation errors")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20181107203122.6861-1-colin.king@canonical.com


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 040b595a91b21b61d6e0d388394b79c85f614e7c)
Signed-off-by: default avatarGreg Hartman <ghartman@google.com>
BUG: 139386237
Change-Id: I67f199a9fa2243a79927c908cbc4f47ac9b16f3d
parent 3b90a75a

drivers/gpu/drm/virtio/virtgpu_kms.c

+3 −1
Original line number Diff line number Diff line
@@ -267,8 +267,10 @@ int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file) 


	get_task_comm(dbgname, current);

	id = virtio_gpu_context_create(vgdev, strlen(dbgname), dbgname);

	if (id < 0)

	if (id < 0) {

		kfree(vfpriv);

		return id;

	}



	vfpriv->ctx_id = id;

	file->driver_priv = vfpriv;