Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 11a61a86 authored by Fengguang Wu's avatar Fengguang Wu Committed by Bjorn Helgaas
Browse files

PCI: dwc: Use PTR_ERR_OR_ZERO to simplify code 



Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR to avoid the
following warnings found by scripts/coccinelle/api/ptr_ret.cocci:

  drivers/pci/dwc/pcie-qcom.c:215:1-3: WARNING: PTR_ERR_OR_ZERO can be used
  drivers/pci/dwc/pcie-qcom.c:247:1-3: WARNING: PTR_ERR_OR_ZERO can be used
  drivers/pci/dwc/pcie-qcom.c:481:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
CC: Kishon Vijay Abraham I <kishon@ti.com>
parent 1f6c4501

drivers/pci/dwc/pcie-qcom.c

+3 −12
Original line number Diff line number Diff line
@@ -212,10 +212,7 @@ static int qcom_pcie_get_resources_v0(struct qcom_pcie *pcie) 
		return PTR_ERR(res->por_reset);



	res->phy_reset = devm_reset_control_get(dev, "phy");

	if (IS_ERR(res->phy_reset))

		return PTR_ERR(res->phy_reset);



	return 0;

	return PTR_ERR_OR_ZERO(res->phy_reset);

}



static int qcom_pcie_get_resources_v1(struct qcom_pcie *pcie)
@@ -244,10 +241,7 @@ static int qcom_pcie_get_resources_v1(struct qcom_pcie *pcie) 
		return PTR_ERR(res->slave_bus);



	res->core = devm_reset_control_get(dev, "core");

	if (IS_ERR(res->core))

		return PTR_ERR(res->core);



	return 0;

	return PTR_ERR_OR_ZERO(res->core);

}



static void qcom_pcie_deinit_v0(struct qcom_pcie *pcie)
@@ -478,10 +472,7 @@ static int qcom_pcie_get_resources_v2(struct qcom_pcie *pcie) 
		return PTR_ERR(res->slave_clk);



	res->pipe_clk = devm_clk_get(dev, "pipe");

	if (IS_ERR(res->pipe_clk))

		return PTR_ERR(res->pipe_clk);



	return 0;

	return PTR_ERR_OR_ZERO(res->pipe_clk);

}



static int qcom_pcie_init_v2(struct qcom_pcie *pcie)