Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 11a1e0ed authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] dvb-usb: warn if return value for USB read/write routines is not checked 



the return values for dvb_usb_generic_rw() and dvb_usb_generic_write()
should be checked, as otherwise the drivers won't be doing the right
thing in the case of errors.

So, add __must_check to both declarations.

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 59dde8e7

drivers/media/usb/dvb-usb/dvb-usb.h

+4 −2
Original line number Diff line number Diff line
@@ -462,8 +462,10 @@ extern int dvb_usb_device_init(struct usb_interface *, 
extern void dvb_usb_device_exit(struct usb_interface *);



/* the generic read/write method for device control */

extern int dvb_usb_generic_rw(struct dvb_usb_device *, u8 *, u16, u8 *, u16,int);

extern int dvb_usb_generic_write(struct dvb_usb_device *, u8 *, u16);

extern int __must_check

dvb_usb_generic_rw(struct dvb_usb_device *, u8 *, u16, u8 *, u16, int);

extern int __must_check

dvb_usb_generic_write(struct dvb_usb_device *, u8 *, u16);



/* commonly used remote control parsing */

extern int dvb_usb_nec_rc_key_to_event(struct dvb_usb_device *, u8[], u32 *, int *);