Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 11836572 authored by vignesh babu's avatar vignesh babu Committed by James Bottomley
Browse files

[SCSI] libiscsi: use is_power_of_2 



Replacing n & (n - 1) for power of 2 check by is_power_of_2(n)

Signed-off-by: default avatarvignesh babu <vignesh.babu@wipro.com>
Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 4545a88f

drivers/scsi/libiscsi.c

+2 −1
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 
#include <linux/types.h>

#include <linux/kfifo.h>

#include <linux/delay.h>

#include <linux/log2.h>

#include <asm/unaligned.h>

#include <net/tcp.h>

#include <scsi/scsi_cmnd.h>
@@ -1700,7 +1701,7 @@ iscsi_session_setup(struct iscsi_transport *iscsit, 
		qdepth = ISCSI_DEF_CMD_PER_LUN;

	}



	if (cmds_max < 2 || (cmds_max & (cmds_max - 1)) ||

	if (!is_power_of_2(cmds_max) ||

	    cmds_max >= ISCSI_MGMT_ITT_OFFSET) {

		if (cmds_max != 0)

			printk(KERN_ERR "iscsi: invalid can_queue of %d. "