Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10d57028 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Ignore invalid batadv_iv_gw during netlink send 



The function batadv_iv_gw_dump stops the processing loop when
batadv_iv_gw_dump_entry returns a non-0 return code. This should only
happen when the buffer is full. Otherwise, an empty message may be
returned by batadv_gw_dump. This empty message will then stop the netlink
dumping of gateway entries. At worst, not a single entry is returned to
userspace even when plenty of possible gateways exist.

Fixes: efb766af ("batman-adv: add B.A.T.M.A.N. IV bat_gw_dump implementations")
Signed-off-by: default avatarSven Eckelmann <sven.eckelmann@openmesh.com>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 3bf2a09d

net/batman-adv/bat_iv_ogm.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -2729,7 +2729,7 @@ static int batadv_iv_gw_dump_entry(struct sk_buff *msg, u32 portid, u32 seq, 
	struct batadv_neigh_ifinfo *router_ifinfo = NULL;

	struct batadv_neigh_ifinfo *router_ifinfo = NULL;

	struct batadv_neigh_node *router;

	struct batadv_neigh_node *router;

	struct batadv_gw_node *curr_gw;

	struct batadv_gw_node *curr_gw;

	int ret = -EINVAL;

	int ret = 0;

	void *hdr;

	void *hdr;





	router = batadv_orig_router_get(gw_node->orig_node, BATADV_IF_DEFAULT);

	router = batadv_orig_router_get(gw_node->orig_node, BATADV_IF_DEFAULT);