Commit 10b0b012 authored Oct 14, 2017 by Wolfram Sang Committed by Ulf Hansson Oct 30, 2017

mmc: cavium: catch all errors when getting regulators

Bail out everytime when mmc_regulator_get_supply() returns an errno, not
only when probing gets deferred. This is currently a no-op, because this
function only returns -EPROBE_DEFER or 0 right now. But if it will throw
another error somewhen, it will be for a reason. (This still doesn't change
that getting regulators is optional, so 0 can still mean no regulators
found). So, let us a) be future proof and b) have driver code which is
easier to understand.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 1f90e9a3

drivers/mmc/host/cavium.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -967,7 +967,7 @@ static int cvm_mmc_of_parse(struct device dev, struct cvm_mmc_slot slot)
		}

		ret = mmc_regulator_get_supply(mmc);
		if (ret == -EPROBE_DEFER)
		if (ret)
		return ret;
		/*
		* Legacy Octeon firmware has no regulator entry, fall-back to