Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10365001 authored by Michael Ellerman's avatar Michael Ellerman Committed by Greg Kroah-Hartman
Browse files

selftests/powerpc: Only test lwm/stmw on big endian 



[ Upstream commit dd3a44c06f7b4f14e90065bf05d62c255b20005f ]

Newer binutils (>= 2.36) refuse to assemble lmw/stmw when building in
little endian mode. That breaks compilation of our alignment handler
test:

  /tmp/cco4l14N.s: Assembler messages:
  /tmp/cco4l14N.s:1440: Error: `lmw' invalid when little-endian
  /tmp/cco4l14N.s:1814: Error: `stmw' invalid when little-endian
  make[2]: *** [../../lib.mk:139: /output/kselftest/powerpc/alignment/alignment_handler] Error 1

These tests do pass on little endian machines, as the kernel will
still emulate those instructions even when running little
endian (which is arguably a kernel bug).

But we don't really need to test that case, so ifdef those
instructions out to get the alignment test building again.

Reported-by: default avatarLibor Pechacek <lpechacek@suse.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Tested-by: default avatarLibor Pechacek <lpechacek@suse.com>
Link: https://lore.kernel.org/r/20210119041800.3093047-1-mpe@ellerman.id.au


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a7a479e1

tools/testing/selftests/powerpc/alignment/alignment_handler.c

+4 −1
Original line number Diff line number Diff line
@@ -384,7 +384,6 @@ int test_alignment_handler_integer(void) 
	LOAD_DFORM_TEST(ldu);

	LOAD_XFORM_TEST(ldx);

	LOAD_XFORM_TEST(ldux);

	LOAD_DFORM_TEST(lmw);

	STORE_DFORM_TEST(stb);

	STORE_XFORM_TEST(stbx);

	STORE_DFORM_TEST(stbu);
@@ -403,7 +402,11 @@ int test_alignment_handler_integer(void) 
	STORE_XFORM_TEST(stdx);

	STORE_DFORM_TEST(stdu);

	STORE_XFORM_TEST(stdux);



#ifdef __BIG_ENDIAN__

	LOAD_DFORM_TEST(lmw);

	STORE_DFORM_TEST(stmw);

#endif



	return rc;

}