Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fb3c244 authored by Eduardo Valentin's avatar Eduardo Valentin Committed by Greg Kroah-Hartman
Browse files

staging: ti-soc-thermal: fix bitfield writing while updating thresholds 



Wrong threshold cold values may be written with current implementation.
This patch fixes the threshold update function by simplifying the
bitfield manipulation sequence.

Signed-off-by: default avatarEduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f5d43b7a

drivers/staging/ti-soc-thermal/ti-bandgap.c

+4 −4
Original line number Diff line number Diff line
@@ -418,10 +418,10 @@ static int ti_bandgap_update_alert_threshold(struct ti_bandgap *bgp, int id, 
	}



	/* write the new threshold values */

	reg_val = thresh_val & ~tsr->threshold_thot_mask;

	reg_val |= (t_hot << __ffs(tsr->threshold_thot_mask));

	reg_val |= thresh_val & ~tsr->threshold_tcold_mask;

	reg_val |= (t_cold << __ffs(tsr->threshold_tcold_mask));

	reg_val = thresh_val &

		  ~(tsr->threshold_thot_mask | tsr->threshold_tcold_mask);

	reg_val |= (t_hot << __ffs(tsr->threshold_thot_mask)) |

		   (t_cold << __ffs(tsr->threshold_tcold_mask));

	ti_bandgap_writel(bgp, reg_val, tsr->bgap_threshold);



	if (err) {