Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f604bfd authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

lib82596: Fix IRQ check in sni_82596_probe 



commit 99218cbf81bf21355a3de61cd46a706d36e900e6 upstream.

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 11597885 ("i825xx: Move the Intel 82586/82593/82596 based drivers")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fe02c434

drivers/net/ethernet/i825xx/sni_82596.c

+2 −1
Original line number Diff line number Diff line
@@ -122,9 +122,10 @@ static int sni_82596_probe(struct platform_device *dev) 
	netdevice->dev_addr[5] = readb(eth_addr + 0x06);

	iounmap(eth_addr);



	if (!netdevice->irq) {

	if (netdevice->irq < 0) {

		printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n",

			__FILE__, netdevice->base_addr);

		retval = netdevice->irq;

		goto probe_failed;

	}