Commit 0f0d1c16 authored Nov 07, 2018 by Vasily Averin Committed by Greg Kroah-Hartman Nov 21, 2018

ext4: fix buffer leak in ext4_xattr_get_block() on error path



commit ecaaf408478b6fb4d9986f9b6652f3824e374f4c upstream.

Fixes: dec214d0 ("ext4: xattr inode deduplication")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 4.13
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0a992da5

fs/ext4/xattr.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2282,8 +2282,10 @@ static struct buffer_head ext4_xattr_get_block(struct inode inode)
		if (!bh)
		return ERR_PTR(-EIO);
		error = ext4_xattr_check_block(inode, bh);
		if (error)
		if (error) {
		brelse(bh);
		return ERR_PTR(error);
		}
		return bh;
		}