Commit 0ec6937e authored Jun 05, 2018 by Colin Ian King Committed by Jens Axboe Jun 05, 2018

lightnvm: pblk: fix resource leak of invalid_bitmap



Currently the error exit path when the emeta could not be
interpreted is via fail_free_ws and this fails to free
invalid_bitmap.  Fix this by adding another exit label and
exiting via this to kfree invalid_bitmap.

Detected by CoverityScan, CID#1469659 ("Resource leak")

Fixes: 48b8d208 ("lightnvm: pblk: garbage collect lines with failed writes")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 21ff1399

drivers/lightnvm/pblk-gc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -203,7 +203,7 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work)
		if (!lba_list) {
		pr_err("pblk: could not interpret emeta (line %d)\n",
		line->id);
		goto fail_free_ws;
		goto fail_free_invalid_bitmap;
		}
		}

		@@ -280,6 +280,7 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work)
		kfree(gc_rq);
		fail_free_lba_list:
		pblk_mfree(lba_list, l_mg->emeta_alloc_type);
		fail_free_invalid_bitmap:
		kfree(invalid_bitmap);
		fail_free_ws:
		kfree(line_ws);