Commit 0e9a5edf authored Dec 02, 2014 by Alexandre Courbot Committed by Linus Walleij Dec 02, 2014

gpio: fix deferred probe detection for legacy API



Commit 14e85c0e ("gpio: remove gpio_descs global array") changed
gpio_to_desc()'s behavior to return NULL not only for GPIOs numbers
not in the valid range, but also for all GPIOs whose controller has not
been probed yet. Although this behavior is more correct (nothing hints
that these GPIO numbers will be populated later), this affects
gpio_request() and gpio_request_one() which call gpiod_request() with a
NULL descriptor, causing it to return -EINVAL instead of the expected
-EPROBE_DEFER for a non-probed GPIO.

gpiod_request() is only called with a descriptor obtained from
gpio_to_desc() from these two functions, so address the issue there.

Other ways to obtain GPIOs rely on well-defined mappings and can thus
return -EPROBE_DEFER only for relevant GPIOs, and are thus not affected
by this issue.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 834296a3

drivers/gpio/gpiolib-legacy.c

+11 −1

Original line number	Diff line number	Diff line
		@@ -24,6 +24,10 @@ int gpio_request_one(unsigned gpio, unsigned long flags, const char *label)

		desc = gpio_to_desc(gpio);

		/* Compatibility: assume unavailable "valid" GPIOs will appear later */
		if (!desc && gpio_is_valid(gpio))
		return -EPROBE_DEFER;

		err = gpiod_request(desc, label);
		if (err)
		return err;
		@@ -62,7 +66,13 @@ EXPORT_SYMBOL_GPL(gpio_request_one);

		int gpio_request(unsigned gpio, const char *label)
		{
		return gpiod_request(gpio_to_desc(gpio), label);
		struct gpio_desc *desc = gpio_to_desc(gpio);

		/* Compatibility: assume unavailable "valid" GPIOs will appear later */
		if (!desc && gpio_is_valid(gpio))
		return -EPROBE_DEFER;

		return gpiod_request(desc, label);
		}
		EXPORT_SYMBOL_GPL(gpio_request);

drivers/gpio/gpiolib.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -77,7 +77,9 @@ struct gpio_desc *gpio_to_desc(unsigned gpio)

		spin_unlock_irqrestore(&gpio_lock, flags);

		if (!gpio_is_valid(gpio))
		WARN(1, "invalid GPIO %d\n", gpio);

		return NULL;
		}
		EXPORT_SYMBOL_GPL(gpio_to_desc);