Commit 0e7894dc authored Jan 10, 2013 by Andy King Committed by Greg Kroah-Hartman Jan 17, 2013

VMCI: Fix "always true condition"



vmci_send_datagram() returns an int, with negative values indicating failure.
But we store it locally in a u32, which makes comparison of >= 0 useless.
Fixed to use an int.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy King <acking@vmware.com>
Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 32b083a3

drivers/misc/vmw_vmci/vmci_guest.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -78,7 +78,7 @@ bool vmci_guest_code_active(void)
	u32 vmci_get_vm_context_id(void)		u32 vmci_get_vm_context_id(void)
	{		{
	if (vm_context_id == VMCI_INVALID_ID) {		if (vm_context_id == VMCI_INVALID_ID) {
	u32 result;		int result;
	struct vmci_datagram get_cid_msg;		struct vmci_datagram get_cid_msg;
	get_cid_msg.dst =		get_cid_msg.dst =
	vmci_make_handle(VMCI_HYPERVISOR_CONTEXT_ID,		vmci_make_handle(VMCI_HYPERVISOR_CONTEXT_ID,