Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d0f660d authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

iser-target: Disable TX completion interrupt coalescing 



This patch explicitly disables TX completion interrupt coalescing logic
in isert_put_response() and isert_put_datain() that was originally added
as an efficiency optimization in commit 95b60f07.

It has been reported that this change can trigger ABORT_TASK timeouts
under certain small block workloads, where disabling coalescing was
required for stability.  According to Sagi, this doesn't impact
overall performance, so go ahead and disable it for now.

Reported-by: default avatarMoussa Ba <moussaba@micron.com>
Reported-by: default avatarSagi Grimberg <sagig@dev.mellanox.co.il>
Cc: <stable@vger.kernel.org> # 3.13+
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 92404e60

drivers/infiniband/ulp/isert/ib_isert.c

+2 −2
Original line number Diff line number Diff line
@@ -2183,7 +2183,7 @@ isert_put_response(struct iscsi_conn *conn, struct iscsi_cmd *cmd) 
		isert_cmd->tx_desc.num_sge = 2;

	}



	isert_init_send_wr(isert_conn, isert_cmd, send_wr, true);

	isert_init_send_wr(isert_conn, isert_cmd, send_wr, false);



	pr_debug("Posting SCSI Response IB_WR_SEND >>>>>>>>>>>>>>>>>>>>>>\n");
@@ -2882,7 +2882,7 @@ isert_put_datain(struct iscsi_conn *conn, struct iscsi_cmd *cmd) 
				     &isert_cmd->tx_desc.iscsi_header);

		isert_init_tx_hdrs(isert_conn, &isert_cmd->tx_desc);

		isert_init_send_wr(isert_conn, isert_cmd,

				   &isert_cmd->tx_desc.send_wr, true);

				   &isert_cmd->tx_desc.send_wr, false);

		isert_cmd->rdma_wr.s_send_wr.next = &isert_cmd->tx_desc.send_wr;

		wr->send_wr_num += 1;

	}