Commit 0cdba07b authored May 05, 2009 by Dave Airlie Committed by Jean Delvare May 05, 2009

i2c-algo-bit: Fix timeout test



When fetching DDC using i2c algo bit, we were often seeing timeouts
before getting valid EDID on a retry. The VESA spec states 2ms is the
DDC timeout, so when this translates into 1 jiffie and we are close
to the end of the time period, it could return with a timeout less than
2ms.

Change this code to use time_after instead of time_after_eq.

Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

parent 4ccc28f7

drivers/i2c/algos/i2c-algo-bit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -104,7 +104,7 @@ static int sclhi(struct i2c_algo_bit_data *adap)
		* chips may hold it low ("clock stretching") while they
		* are processing data internally.
		*/
		if (time_after_eq(jiffies, start + adap->timeout))
		if (time_after(jiffies, start + adap->timeout))
		return -ETIMEDOUT;
		cond_resched();
		}