Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ca54b29 authored by Sean Young's avatar Sean Young Committed by Mauro Carvalho Chehab
Browse files

media: rc: be less noisy when driver misbehaves 



Since commit 48231f28 ("media: rc: drivers should produce alternate
pulse and space timing events"), on meson-ir we are regularly producing
errors. Reduce to warning level and only warn once to avoid flooding
the log.

A proper fix for meson-ir is going to be too large for v4.18.

Signed-off-by: default avatarSean Young <sean@mess.org>
Cc: stable@vger.kernel.org # 4.17+
Tested-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 7daf201d

drivers/media/rc/rc-ir-raw.c

+4 −4
Original line number Diff line number Diff line
@@ -30,13 +30,13 @@ static int ir_raw_event_thread(void *data) 
		while (kfifo_out(&raw->kfifo, &ev, 1)) {

			if (is_timing_event(ev)) {

				if (ev.duration == 0)

					dev_err(&dev->dev, "nonsensical timing event of duration 0");

					dev_warn_once(&dev->dev, "nonsensical timing event of duration 0");

				if (is_timing_event(raw->prev_ev) &&

				    !is_transition(&ev, &raw->prev_ev))

					dev_err(&dev->dev, "two consecutive events of type %s",

					dev_warn_once(&dev->dev, "two consecutive events of type %s",

						      TO_STR(ev.pulse));

				if (raw->prev_ev.reset && ev.pulse == 0)

					dev_err(&dev->dev, "timing event after reset should be pulse");

					dev_warn_once(&dev->dev, "timing event after reset should be pulse");

			}

			list_for_each_entry(handler, &ir_raw_handler_list, list)

				if (dev->enabled_protocols &