Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c971eda authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: usbip: remove unneeded MODULE_VERSION() usage 



MODULE_VERSION is useless for in-kernel drivers, so just remove all
usage of it in the USB usbip drivers.  Along with this, the
USBIP_VERSION macros was removed as is was also pointless, as well as
printing out the driver version to the syslog at init time, which is not
necessary at all.

Cc: Valentina Manea <valentina.manea.m@gmail.com>
Acked-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c35c376f

drivers/usb/usbip/stub_main.c

+0 −2
Original line number Diff line number Diff line
@@ -302,7 +302,6 @@ static int __init usbip_host_init(void) 
		goto err_create_file;

	}



	pr_info(DRIVER_DESC " v" USBIP_VERSION "\n");

	return ret;



err_create_file:
@@ -335,4 +334,3 @@ module_exit(usbip_host_exit); 
MODULE_AUTHOR(DRIVER_AUTHOR);

MODULE_DESCRIPTION(DRIVER_DESC);

MODULE_LICENSE("GPL");
 
MODULE_VERSION(USBIP_VERSION);

drivers/usb/usbip/usbip_common.c

+0 −2
Original line number Diff line number Diff line
@@ -763,7 +763,6 @@ static int __init usbip_core_init(void) 
{

	int ret;



	pr_info(DRIVER_DESC " v" USBIP_VERSION "\n");

	ret = usbip_init_eh();

	if (ret)

		return ret;
@@ -783,4 +782,3 @@ module_exit(usbip_core_exit); 
MODULE_AUTHOR(DRIVER_AUTHOR);

MODULE_DESCRIPTION(DRIVER_DESC);

MODULE_LICENSE("GPL");
 
MODULE_VERSION(USBIP_VERSION);

drivers/usb/usbip/usbip_common.h

+0 −2
Original line number Diff line number Diff line
@@ -34,8 +34,6 @@ 
#include <linux/sched/task.h>

#include <uapi/linux/usbip.h>



#define USBIP_VERSION "1.0.0"



#undef pr_fmt



#ifdef DEBUG

drivers/usb/usbip/vhci_hcd.c

+0 −2
Original line number Diff line number Diff line
@@ -1516,7 +1516,6 @@ static int __init vhci_hcd_init(void) 
		}

	}



	pr_info(DRIVER_DESC " v" USBIP_VERSION "\n");

	return ret;



err_add_hcd:
@@ -1542,4 +1541,3 @@ module_exit(vhci_hcd_exit); 
MODULE_AUTHOR(DRIVER_AUTHOR);

MODULE_DESCRIPTION(DRIVER_DESC);

MODULE_LICENSE("GPL");
 
MODULE_VERSION(USBIP_VERSION);