Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c0aa844 authored by Jingoo Han's avatar Jingoo Han Committed by Herbert Xu
Browse files

hwrng: pixocell - Use devm_clk_get() 



Use devm_clk_get() to make cleanup paths simpler.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 0574bce9

drivers/char/hw_random/picoxcell-rng.c

+2 −6
Original line number Diff line number Diff line
@@ -108,7 +108,7 @@ static int picoxcell_trng_probe(struct platform_device *pdev) 
	if (IS_ERR(rng_base))

		return PTR_ERR(rng_base);



	rng_clk = clk_get(&pdev->dev, NULL);

	rng_clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(rng_clk)) {

		dev_warn(&pdev->dev, "no clk\n");

		return PTR_ERR(rng_clk);
@@ -117,7 +117,7 @@ static int picoxcell_trng_probe(struct platform_device *pdev) 
	ret = clk_enable(rng_clk);

	if (ret) {

		dev_warn(&pdev->dev, "unable to enable clk\n");

		goto err_enable;

		return ret;

	}



	picoxcell_trng_start();
@@ -132,9 +132,6 @@ static int picoxcell_trng_probe(struct platform_device *pdev) 


err_register:

	clk_disable(rng_clk);

err_enable:

	clk_put(rng_clk);



	return ret;

}
@@ -142,7 +139,6 @@ static int picoxcell_trng_remove(struct platform_device *pdev) 
{

	hwrng_unregister(&picoxcell_trng);

	clk_disable(rng_clk);

	clk_put(rng_clk);



	return 0;

}