Commit 0b857b44 authored Jul 31, 2016 by Roland Dreier Committed by Sagi Grimberg Aug 03, 2016

nvme-rdma: Don't leak uninitialized memory in connect request private data



Zero out the full nvme_rdma_cm_req structure before sending it.
Otherwise we end up leaking kernel memory in the reserved field, which
might break forward compatibility in the future.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

parent 07f00f06

drivers/nvme/host/rdma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1269,7 +1269,7 @@ static int nvme_rdma_route_resolved(struct nvme_rdma_queue *queue)
		{
		struct nvme_rdma_ctrl *ctrl = queue->ctrl;
		struct rdma_conn_param param = { };
		struct nvme_rdma_cm_req priv;
		struct nvme_rdma_cm_req priv = { };
		int ret;

		param.qp_num = queue->qp->qp_num;