Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b6c4b14 authored by Roel Kluin's avatar Roel Kluin Committed by James Bottomley
Browse files

[SCSI] aic7xxx: Test opcode, not definition in aicasm:type_check() 



This fixes a bug that we treat all sequencer operations as ands and
never do the additional invalid bit checks non-and operations require
because the if () to determine this has an operand which is always
true at the end of the or statement.

Signed-off-by: default avatarRoel Kluin <12o3l@tiscali.nl>
Acked-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 639db475

drivers/scsi/aic7xxx/aicasm/aicasm_gram.y

+1 −1
Original line number Original line Diff line number Diff line
@@ -1837,7 +1837,7 @@ type_check(symbol_t *symbol, expression_t *expression, int opcode) 
	int and_op;

	int and_op;





	and_op = FALSE;

	and_op = FALSE;

	if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || AIC_OP_JZ)

	if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || opcode == AIC_OP_JZ)

		and_op = TRUE;

		and_op = TRUE;





	/*

	/*