Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b56d1c8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

media: staging: atomisp: fix bounds checking in mt9m114_s_exposure_selection() 



These clamp_t() calls are no-ops because we don't save the results.  It
leads to an array out of bounds bug.

Fixes: a49d2536 ("staging/atomisp: Add support for the Intel IPU v2")

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent ceb25b3c

drivers/staging/media/atomisp/i2c/mt9m114.c

+4 −4
Original line number Diff line number Diff line
@@ -1209,10 +1209,10 @@ static int mt9m114_s_exposure_selection(struct v4l2_subdev *sd, 
		return -EINVAL;

	}



	clamp_t(int, win_left, 0, 4);

	clamp_t(int, win_top, 0, 4);

	clamp_t(int, win_right, 0, 4);

	clamp_t(int, win_bottom, 0, 4);

	win_left   = clamp_t(int, win_left, 0, 4);

	win_top    = clamp_t(int, win_top, 0, 4);

	win_right  = clamp_t(int, win_right, 0, 4);

	win_bottom = clamp_t(int, win_bottom, 0, 4);



	ret = mt9m114_write_reg_array(client, mt9m114_exp_average, NO_POLLING);

	if (ret) {