Commit 0b1e1eb7 authored Jun 03, 2016 by Boris Brezillon

drm: atmel-hlcdc: Fix OF graph parsing

atmel_hlcdc_create_outputs() iterates over OF graph nodes and releases
the node (using of_node_put()) after each iteration, which is wrong
since for_each_endpoint_of_node() is already taking care of that.

Move the of_node_put() call in the error path.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reviewed-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Fixes: 17a8e03e ("drm: atmel-hlcdc: rework the output code to support drm bridges")

parent 1b7e38b9

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -266,20 +266,22 @@ int atmel_hlcdc_create_outputs(struct drm_device *dev)
		if (!ret)
		ret = atmel_hlcdc_check_endpoint(dev, &ep);

		if (ret) {
		of_node_put(ep_np);
		if (ret)
		return ret;
		}
		}

		for_each_endpoint_of_node(dev->dev->of_node, ep_np) {
		ret = of_graph_parse_endpoint(ep_np, &ep);
		if (!ret)
		ret = atmel_hlcdc_attach_endpoint(dev, &ep);

		if (ret) {
		of_node_put(ep_np);
		if (ret)
		return ret;
		}
		}

		return 0;
		}