Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b1c42a0 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: stop GC when the victim becomes fully valid 



We must stop GC, once the segment becomes fully valid. Otherwise, it can
produce another dirty segments by moving valid blocks in the segment partially.

Ramon hit no free segment panic sometimes and saw this case happens when
validating reliable file pinning feature.

Signed-off-by: default avatarRamon Pantin <pantin@google.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 64972d5f

fs/f2fs/gc.c

+8 −2
Original line number Diff line number Diff line
@@ -1012,8 +1012,14 @@ static int gc_data_segment(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, 
		block_t start_bidx;

		nid_t nid = le32_to_cpu(entry->nid);



		/* stop BG_GC if there is not enough free sections. */

		if (gc_type == BG_GC && has_not_enough_free_secs(sbi, 0, 0))

		/*

		 * stop BG_GC if there is not enough free sections.

		 * Or, stop GC if the segment becomes fully valid caused by

		 * race condition along with SSR block allocation.

		 */

		if ((gc_type == BG_GC && has_not_enough_free_secs(sbi, 0, 0)) ||

				get_valid_blocks(sbi, segno, false) ==

							sbi->blocks_per_seg)

			return submitted;



		if (check_valid_map(sbi, segno, off) == 0)