Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b1a989e authored by Pieter Jansen van Vuuren's avatar Pieter Jansen van Vuuren Committed by David S. Miller
Browse files

nfp: flower: move route ack control messages out of the workqueue 



Previously we processed the route ack control messages in the workqueue,
this unnecessarily loads the workqueue. We can deal with these messages
sooner as we know we are going to drop them.

Fixes: 8e6a9046 ("nfp: flower vxlan neighbour offload")
Signed-off-by: default avatarPieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: default avatarSimon Horman <simon.horman@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bc05f9bc

drivers/net/ethernet/netronome/nfp/flower/cmsg.c

+3 −3
Original line number Diff line number Diff line
@@ -258,9 +258,6 @@ nfp_flower_cmsg_process_one_rx(struct nfp_app *app, struct sk_buff *skb) 
	case NFP_FLOWER_CMSG_TYPE_ACTIVE_TUNS:

		nfp_tunnel_keep_alive(app, skb);

		break;

	case NFP_FLOWER_CMSG_TYPE_TUN_NEIGH:

		/* Acks from the NFP that the route is added - ignore. */

		break;

	default:

		nfp_flower_cmsg_warn(app, "Cannot handle invalid repr control type %u\n",

				     type);
@@ -306,6 +303,9 @@ void nfp_flower_cmsg_rx(struct nfp_app *app, struct sk_buff *skb) 
		   nfp_flower_process_mtu_ack(app, skb)) {

		/* Handle MTU acks outside wq to prevent RTNL conflict. */

		dev_consume_skb_any(skb);

	} else if (cmsg_hdr->type == NFP_FLOWER_CMSG_TYPE_TUN_NEIGH) {

		/* Acks from the NFP that the route is added - ignore. */

		dev_consume_skb_any(skb);

	} else {

		skb_queue_tail(&priv->cmsg_skbs, skb);

		schedule_work(&priv->cmsg_work);