Commit 0af051ba authored Dec 23, 2011 by Patrick McHardy Committed by Pablo Neira Ayuso Dec 23, 2011

netfilter: nf_nat: remove obsolete check in nf_nat_mangle_udp_packet()



The packet size check originates from a time when UDP helpers could
accidentally mangle incorrect packets (NEWNAT) and is unnecessary
nowadays since the conntrack helpers invoke the NAT helpers for the
proper packet directly.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 40cfb706

net/ipv4/netfilter/nf_nat_helper.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -253,12 +253,6 @@ nf_nat_mangle_udp_packet(struct sk_buff *skb,
		struct udphdr *udph;
		int datalen, oldlen;

		/* UDP helpers might accidentally mangle the wrong packet */
		iph = ip_hdr(skb);
		if (skb->len < iph->ihl4 + sizeof(udph) +
		match_offset + match_len)
		return 0;

		if (!skb_make_writable(skb, skb->len))
		return 0;