Commit 0abd6bdd authored Jan 21, 2017 by Dan Carpenter Committed by Bjorn Andersson Jan 30, 2017

rpmsg: unlock on error in rpmsg_eptdev_read()

We should unlock before returning if skb_dequeue() returns a NULL.

Fixes: c0cdc19f ("rpmsg: Driver for user space endpoint interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent b70ea16d

drivers/rpmsg/rpmsg_char.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -209,11 +209,10 @@ static ssize_t rpmsg_eptdev_read(struct file filp, char __user buf,
		}

		skb = skb_dequeue(&eptdev->queue);
		spin_unlock_irqrestore(&eptdev->queue_lock, flags);
		if (!skb)
		return -EFAULT;

		spin_unlock_irqrestore(&eptdev->queue_lock, flags);

		use = min_t(size_t, len, skb->len);
		if (copy_to_user(buf, skb->data, use))
		use = -EFAULT;