Commit 0a9debf1 authored Feb 04, 2020 by Malcolm Priestley Committed by Greg Kroah-Hartman Feb 28, 2020

staging: vt6656: fix sign of rx_dbm to bb_pre_ed_rssi.



commit 93134df520f23f4e9998c425b8987edca7016817 upstream.

bb_pre_ed_rssi is an u8 rx_dm always returns negative signed
values add minus operator to always yield positive.

fixes issue where rx sensitivity is always set to maximum because
the unsigned numbers were always greater then 100.

Fixes: 63b9907f ("staging: vt6656: mac80211 conversion: create rx function.")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Link: https://lore.kernel.org/r/aceac98c-6e69-3ce1-dfec-2bf27b980221@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a4307700

drivers/staging/vt6656/dpc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -130,7 +130,7 @@ int vnt_rx_data(struct vnt_private priv, struct vnt_rcb ptr_rcb,

		vnt_rf_rssi_to_dbm(priv, *rssi, &rx_dbm);

		priv->bb_pre_ed_rssi = (u8)rx_dbm + 1;
		priv->bb_pre_ed_rssi = (u8)-rx_dbm + 1;
		priv->current_rssi = priv->bb_pre_ed_rssi;

		skb_pull(skb, 8);