Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a9cd0a8 authored by Kees Cook's avatar Kees Cook Committed by Jiri Kosina
Browse files

HID: lenovo-tpkbd: validate output report details 



A HID device could send a malicious output report that would cause the
lenovo-tpkbd HID driver to write just beyond the output report allocation
during initialization, causing a heap overflow:

[   76.109807] usb 1-1: New USB device found, idVendor=17ef, idProduct=6009
...
[   80.462540] BUG kmalloc-192 (Tainted: G        W   ): Redzone overwritten

CVE-2013-2894

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 0fb6bd06

drivers/hid/hid-lenovo-tpkbd.c

+9 −1
Original line number Diff line number Diff line
@@ -339,7 +339,15 @@ static int tpkbd_probe_tp(struct hid_device *hdev) 
	struct tpkbd_data_pointer *data_pointer;

	size_t name_sz = strlen(dev_name(dev)) + 16;

	char *name_mute, *name_micmute;

	int ret;

	int i, ret;



	/* Validate required reports. */

	for (i = 0; i < 4; i++) {

		if (!hid_validate_values(hdev, HID_FEATURE_REPORT, 4, i, 1))

			return -ENODEV;

	}

	if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 3, 0, 2))

		return -ENODEV;



	if (sysfs_create_group(&hdev->dev.kobj,

				&tpkbd_attr_group_pointer)) {