Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a90e251 authored by Gavin Shan's avatar Gavin Shan Committed by David S. Miller
Browse files

net/ncsi: Fix length of GVI response packet 



The length of GVI (GetVersionInfo) response packet should be 40 instead
of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats.

 # ethtool --ncsi eth0 swstats
     :
 RESPONSE     OK       TIMEOUT  ERROR
 =======================================
 GVI          0        0        2

With this applied, no error reported on GVI response packets:

 # ethtool --ncsi eth0 swstats
     :
 RESPONSE     OK       TIMEOUT  ERROR
 =======================================
 GVI          2        0        0

Signed-off-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: default avatarSamuel Mendoza-Jonas <sam@mendozajonas.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 52b4c862

net/ncsi/ncsi-rsp.c

+1 −1
Original line number Diff line number Diff line
@@ -959,7 +959,7 @@ static struct ncsi_rsp_handler { 
	{ NCSI_PKT_RSP_EGMF,    4, ncsi_rsp_handler_egmf    },

	{ NCSI_PKT_RSP_DGMF,    4, ncsi_rsp_handler_dgmf    },

	{ NCSI_PKT_RSP_SNFC,    4, ncsi_rsp_handler_snfc    },

	{ NCSI_PKT_RSP_GVI,    36, ncsi_rsp_handler_gvi     },

	{ NCSI_PKT_RSP_GVI,    40, ncsi_rsp_handler_gvi     },

	{ NCSI_PKT_RSP_GC,     32, ncsi_rsp_handler_gc      },

	{ NCSI_PKT_RSP_GP,     -1, ncsi_rsp_handler_gp      },

	{ NCSI_PKT_RSP_GCPS,  172, ncsi_rsp_handler_gcps    },