Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a7480bd authored by Dan Carpenter's avatar Dan Carpenter Committed by Bjorn Andersson
Browse files

rpmsg: glink: Unlock on error in qcom_glink_request_intent() 



If qcom_glink_tx() fails, then we need to unlock before returning the
error code.

Fixes: 27b9c5b6 ("rpmsg: glink: Request for intents when unavailable")
Acked-by: default avatarSricharan R <sricharan@codeaurora.org>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 2bd6bf03

drivers/rpmsg/qcom_glink_native.c

+2 −1
Original line number Diff line number Diff line
@@ -1197,7 +1197,7 @@ static int qcom_glink_request_intent(struct qcom_glink *glink, 


	ret = qcom_glink_tx(glink, &cmd, sizeof(cmd), NULL, 0, true);

	if (ret)

		return ret;

		goto unlock;



	ret = wait_for_completion_timeout(&channel->intent_req_comp, 10 * HZ);

	if (!ret) {
@@ -1207,6 +1207,7 @@ static int qcom_glink_request_intent(struct qcom_glink *glink, 
		ret = channel->intent_req_result ? 0 : -ECANCELED;

	}



unlock:

	mutex_unlock(&channel->intent_req_lock);

	return ret;

}