Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09f4114e authored by Johannes Berg's avatar Johannes Berg
Browse files

mac80211: warn if unexpectedly removing stations 



When an interface is brought down it must have been
disconnected (or similar) in all modes other than WDS,
so warn if any stations were removed in other modes.

Tested-by: default avatarBen Greear <greearb@candelatech.com>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent b998e8bb

net/mac80211/iface.c

+7 −5
Original line number Original line Diff line number Diff line
@@ -747,7 +747,7 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata, 
	unsigned long flags;

	unsigned long flags;

	struct sk_buff *skb, *tmp;

	struct sk_buff *skb, *tmp;

	u32 hw_reconf_flags = 0;

	u32 hw_reconf_flags = 0;

	int i;

	int i, flushed;





	clear_bit(SDATA_STATE_RUNNING, &sdata->state);

	clear_bit(SDATA_STATE_RUNNING, &sdata->state);
@@ -772,11 +772,13 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata, 
	 * (because if we remove a STA after ops->remove_interface()

	 * (because if we remove a STA after ops->remove_interface()

	 * the driver will have removed the vif info already!)

	 * the driver will have removed the vif info already!)

	 *

	 *

	 * This is relevant only in AP, WDS and mesh modes, since in

	 * This is relevant only in WDS mode, in all other modes we've

	 * all other modes we've already removed all stations when

	 * already removed all stations when disconnecting or similar,

	 * disconnecting etc.

	 * so warn otherwise.

	 */

	 */

	sta_info_flush(sdata);

	flushed = sta_info_flush(sdata);

	WARN_ON_ONCE((sdata->vif.type != NL80211_IFTYPE_WDS && flushed > 0) ||

		     (sdata->vif.type == NL80211_IFTYPE_WDS && flushed != 1));





	/*

	/*

	 * Don't count this interface for promisc/allmulti while it

	 * Don't count this interface for promisc/allmulti while it