Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09d9bae0 authored by Russell King's avatar Russell King Committed by Russell King
Browse files

[ARM] sparse: fix several warnings 



arch/arm/kernel/process.c:270:6: warning: symbol 'show_fpregs' was not declared. Should it be static?

This function isn't used, so can be removed.

arch/arm/kernel/setup.c:532:9: warning: symbol 'len' shadows an earlier one
arch/arm/kernel/setup.c:524:6: originally declared here

A function containing two 'len's.

arch/arm/mm/fault-armv.c:188:13: warning: symbol 'check_writebuffer_bugs' was not declared. Should it be static?
arch/arm/mm/mmap.c:122:5: warning: symbol 'valid_phys_addr_range' was not declared. Should it be static?
arch/arm/mm/mmap.c:137:5: warning: symbol 'valid_mmap_phys_addr_range' was not declared. Should it be static?

Missing includes.

arch/arm/kernel/traps.c:71:77: warning: Using plain integer as NULL pointer
arch/arm/mm/ioremap.c:355:46: error: incompatible types in comparison expression (different address spaces)

Sillies.

Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 22acc4e6

arch/arm/kernel/process.c

+0 −29
Original line number Diff line number Diff line
@@ -267,35 +267,6 @@ void show_regs(struct pt_regs * regs) 
	__backtrace();

}



void show_fpregs(struct user_fp *regs)

{

	int i;



	for (i = 0; i < 8; i++) {

		unsigned long *p;

		char type;



		p = (unsigned long *)(regs->fpregs + i);



		switch (regs->ftype[i]) {

			case 1: type = 'f'; break;

			case 2: type = 'd'; break;

			case 3: type = 'e'; break;

			default: type = '?'; break;

		}

		if (regs->init_flag)

			type = '?';



		printk("  f%d(%c): %08lx %08lx %08lx%c",

			i, type, p[0], p[1], p[2], i & 1 ? '\n' : ' ');

	}

			



	printk("FPSR: %08lx FPCR: %08lx\n",

		(unsigned long)regs->fpsr,

		(unsigned long)regs->fpcr);

}



/*

 * Free current thread data structures etc..

 */

arch/arm/kernel/setup.c

+3 −3
Original line number Diff line number Diff line
@@ -529,12 +529,12 @@ static void __init parse_cmdline(char **cmdline_p, char *from) 
			struct early_params *p;



			for (p = &__early_begin; p < &__early_end; p++) {

				int len = strlen(p->arg);

				int arglen = strlen(p->arg);



				if (memcmp(from, p->arg, len) == 0) {

				if (memcmp(from, p->arg, arglen) == 0) {

					if (to != command_line)

						to -= 1;

					from += len;

					from += arglen;

					p->fn(&from);



					while (*from != ' ' && *from != '\0')

arch/arm/kernel/traps.c

+2 −1
Original line number Diff line number Diff line
@@ -68,7 +68,8 @@ void dump_backtrace_entry(unsigned long where, unsigned long from, unsigned long 
 */

static int verify_stack(unsigned long sp)

{

	if (sp < PAGE_OFFSET || (sp > (unsigned long)high_memory && high_memory != 0))

	if (sp < PAGE_OFFSET ||

	    (sp > (unsigned long)high_memory && high_memory != NULL))

		return -EFAULT;



	return 0;

arch/arm/mm/fault-armv.c

+1 −0
Original line number Diff line number Diff line
@@ -17,6 +17,7 @@ 
#include <linux/init.h>

#include <linux/pagemap.h>



#include <asm/bugs.h>

#include <asm/cacheflush.h>

#include <asm/cachetype.h>

#include <asm/pgtable.h>

arch/arm/mm/ioremap.c

+4 −5
Original line number Diff line number Diff line
@@ -333,15 +333,14 @@ __arm_ioremap(unsigned long phys_addr, size_t size, unsigned int mtype) 
}

EXPORT_SYMBOL(__arm_ioremap);



void __iounmap(volatile void __iomem *addr)

void __iounmap(volatile void __iomem *io_addr)

{

	void *addr = (void *)(PAGE_MASK & (unsigned long)io_addr);

#ifndef CONFIG_SMP

	struct vm_struct **p, *tmp;

#endif

	unsigned int section_mapping = 0;



	addr = (volatile void __iomem *)(PAGE_MASK & (unsigned long)addr);



#ifndef CONFIG_SMP

	/*

	 * If this is a section based mapping we need to handle it
@@ -367,6 +366,6 @@ void __iounmap(volatile void __iomem *addr) 
#endif



	if (!section_mapping)

		vunmap((void __force *)addr);

		vunmap(addr);

}

EXPORT_SYMBOL(__iounmap);