Commit 09b17f32 authored Mar 06, 2018 by Tomas Winkler Committed by Jarkko Sakkinen Mar 23, 2018

tpm_crb: use __le64 annotated variable for response buffer address



use __le64 annotated variable for response buffer address as this is
read in little endian format form the register.

This suppresses sparse warning
drivers/char/tpm/tpm_crb.c:558:18: warning: cast to restricted __le64

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

parent 62c09e12

drivers/char/tpm/tpm_crb.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -471,6 +471,7 @@ static int crb_map_io(struct acpi_device device, struct crb_priv priv,
		u32 pa_high, pa_low;
		u64 cmd_pa;
		u32 cmd_size;
		__le64 __rsp_pa;
		u64 rsp_pa;
		u32 rsp_size;
		int ret;
		@@ -536,8 +537,8 @@ static int crb_map_io(struct acpi_device device, struct crb_priv priv,
		goto out;
		}

		memcpy_fromio(&rsp_pa, &priv->regs_t->ctrl_rsp_pa, 8);
		rsp_pa = le64_to_cpu(rsp_pa);
		memcpy_fromio(&__rsp_pa, &priv->regs_t->ctrl_rsp_pa, 8);
		rsp_pa = le64_to_cpu(__rsp_pa);
		rsp_size = crb_fixup_cmd_size(dev, &io_res, rsp_pa,
		ioread32(&priv->regs_t->ctrl_rsp_size));