Commit 09954ea9 authored Jul 06, 2017 by Shawn Lin Committed by Ulf Hansson Aug 30, 2017

mmc: mxcmmc: check the return value of mxcmci_finish_data



We got a compile warning for mxcmmc,

drivers/mmc/host/mxcmmc.c: In function 'mxcmci_data_done':
drivers/mmc/host/mxcmmc.c:661:6: warning: variable 'data_error' set but
not used [-Wunused-but-set-variable]

The easiest method is to remove the data_error. But looking into
the code closely, I think we should check the return value of
mxcmci_finish_data as if it got data->error(the same as data_error),
we shouldn't try to read the response.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent e5d0e17b

drivers/mmc/host/mxcmmc.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -681,6 +681,9 @@ static void mxcmci_data_done(struct mxcmci_host *host, unsigned int stat)

		spin_unlock_irqrestore(&host->lock, flags);

		if (data_error)
		return;

		mxcmci_read_response(host, stat);
		host->cmd = NULL;