Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 092bd5c2 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

uwb: Re-use DEFINE_SHOW_ATTRIBUTE() macro 



...instead of open coding file operations followed by custom ->open()
callbacks per each attribute.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9e902c59

drivers/uwb/uwb-debug.c

+4 −28
Original line number Diff line number Diff line
@@ -206,7 +206,7 @@ static const struct file_operations command_fops = { 
	.owner  = THIS_MODULE,

};



static int reservations_print(struct seq_file *s, void *p)

static int reservations_show(struct seq_file *s, void *p)

{

	struct uwb_rc *rc = s->private;

	struct uwb_rsv *rsv;
@@ -240,21 +240,9 @@ static int reservations_print(struct seq_file *s, void *p) 


	return 0;

}

DEFINE_SHOW_ATTRIBUTE(reservations);



static int reservations_open(struct inode *inode, struct file *file)

{

	return single_open(file, reservations_print, inode->i_private);

}



static const struct file_operations reservations_fops = {

	.open    = reservations_open,

	.read    = seq_read,

	.llseek  = seq_lseek,

	.release = single_release,

	.owner   = THIS_MODULE,

};



static int drp_avail_print(struct seq_file *s, void *p)

static int drp_avail_show(struct seq_file *s, void *p)

{

	struct uwb_rc *rc = s->private;
@@ -264,19 +252,7 @@ static int drp_avail_print(struct seq_file *s, void *p) 


	return 0;

}



static int drp_avail_open(struct inode *inode, struct file *file)

{

	return single_open(file, drp_avail_print, inode->i_private);

}



static const struct file_operations drp_avail_fops = {

	.open    = drp_avail_open,

	.read    = seq_read,

	.llseek  = seq_lseek,

	.release = single_release,

	.owner   = THIS_MODULE,

};

DEFINE_SHOW_ATTRIBUTE(drp_avail);



static void uwb_dbg_channel_changed(struct uwb_pal *pal, int channel)

{