Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0840ff76 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192u: remove redundant null check on array alg 



u.crypt.alg is an array of u8 integers and hence the null check on
this array is redundant and can be removed.

Detected with CoverityScan, CID#143214 ("Array compared against 0")

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7a976ce1

drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

+15 −17
Original line number Diff line number Diff line
@@ -3056,7 +3056,6 @@ static int ieee80211_wpa_set_encryption(struct ieee80211_device *ieee, 
	} else

		sec.flags &= ~SEC_ACTIVE_KEY;



	if (param->u.crypt.alg != NULL) {

	memcpy(sec.keys[param->u.crypt.idx],

	       param->u.crypt.key,

	       param->u.crypt.key_len);
@@ -3073,7 +3072,6 @@ static int ieee80211_wpa_set_encryption(struct ieee80211_device *ieee, 
		sec.flags |= SEC_LEVEL;

		sec.level = SEC_LEVEL_3;

	}

	}

 done:

	if (ieee->set_security)

		ieee->set_security(ieee->dev, &sec);