Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0832a462 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Greg Kroah-Hartman
Browse files

tty: serial: cpm_uart: make use of for_each_node_by_type() 



Instead of open-coding loop with of_find_node_by_type(), let's use canned
macro.

Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aea9a80b

drivers/tty/serial/cpm_uart/cpm_uart_core.c

+10 −8
Original line number Diff line number Diff line
@@ -1302,7 +1302,7 @@ static int __init cpm_uart_console_setup(struct console *co, char *options) 
	struct uart_cpm_port *pinfo;

	struct uart_port *port;



	struct device_node *np = NULL;

	struct device_node *np;

	int i = 0;



	if (co->index >= UART_NR) {
@@ -1311,17 +1311,19 @@ static int __init cpm_uart_console_setup(struct console *co, char *options) 
		return -ENODEV;

	}



	do {

		np = of_find_node_by_type(np, "serial");

		if (!np)

			return -ENODEV;



	for_each_node_by_type(np, "serial") {

		if (!of_device_is_compatible(np, "fsl,cpm1-smc-uart") &&

		    !of_device_is_compatible(np, "fsl,cpm1-scc-uart") &&

		    !of_device_is_compatible(np, "fsl,cpm2-smc-uart") &&

		    !of_device_is_compatible(np, "fsl,cpm2-scc-uart"))

			i--;

	} while (i++ != co->index);

			continue;



		if (i++ == co->index)

			break;

	}



	if (!np)

		return -ENODEV;



	pinfo = &cpm_uart_ports[co->index];