Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07bbeaf1 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

ieee1394: fix broken signed char assumption. 

"ack_code" is assigned (and tested against) negative numbers, but was
declared as "char".  Which only works if "char" is signed - which it
necessarily isn't.

So make that signedness assumption specific.
parent 184f6eb8

drivers/ieee1394/ieee1394_core.h

+2 −2
Original line number Diff line number Diff line
@@ -38,8 +38,8 @@ struct hpsb_packet { 


        /* These are core internal. */

        signed char tlabel;

        char ack_code;

        char tcode;

	signed char ack_code;

	unsigned char tcode;



        unsigned expect_response:1;

        unsigned no_waiter:1;