Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0781c874 authored by Kent Overstreet's avatar Kent Overstreet
Browse files

bcache: Drop unneeded blk_sync_queue() calls 

this is needed for the queue/block device we created (it's done by
blk_cleanup_queue() which we do call) - but calling it for the block devices we
only opened is pointless.

Change-Id: I53dfded14ed15b9581d10ca8399d5e1b3abbf9f2
parent 789d21db

drivers/md/bcache/super.c

+2 −8
Original line number Diff line number Diff line
@@ -1084,12 +1084,8 @@ static void cached_dev_free(struct closure *cl) 


	mutex_unlock(&bch_register_lock);



	if (!IS_ERR_OR_NULL(dc->bdev)) {

		if (dc->bdev->bd_disk)

			blk_sync_queue(bdev_get_queue(dc->bdev));



	if (!IS_ERR_OR_NULL(dc->bdev))

		blkdev_put(dc->bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);

	}



	wake_up(&unregister_wait);
@@ -1817,10 +1813,8 @@ void bch_cache_release(struct kobject *kobj) 
	if (ca->sb_bio.bi_inline_vecs[0].bv_page)

		put_page(ca->sb_bio.bi_io_vec[0].bv_page);



	if (!IS_ERR_OR_NULL(ca->bdev)) {

		blk_sync_queue(bdev_get_queue(ca->bdev));

	if (!IS_ERR_OR_NULL(ca->bdev))

		blkdev_put(ca->bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);

	}



	kfree(ca);

	module_put(THIS_MODULE);