Commit 06fe9323 authored Mar 19, 2018 by Akinobu Mita Committed by Mauro Carvalho Chehab Apr 04, 2018

media: ov5645: add missing of_node_put() in error path



The device node obtained with of_graph_get_next_endpoint() should be
released by calling of_node_put().  But it was not released when
v4l2_fwnode_endpoint_parse() failed.

This change moves the of_node_put() call before the error check and
fixes the issue.

Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Acked-by: Todor Tomov <todor.tomov@linaro.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent e6441fde

drivers/media/i2c/ov5645.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1131,13 +1131,14 @@ static int ov5645_probe(struct i2c_client *client,

		ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(endpoint),
		&ov5645->ep);

		of_node_put(endpoint);

		if (ret < 0) {
		dev_err(dev, "parsing endpoint node failed\n");
		return ret;
		}

		of_node_put(endpoint);

		if (ov5645->ep.bus_type != V4L2_MBUS_CSI2) {
		dev_err(dev, "invalid bus type, must be CSI2\n");
		return -EINVAL;