Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06f5a1f3 authored by Chinh T Cao's avatar Chinh T Cao Committed by Greg Kroah-Hartman
Browse files

ice: Change req_speeds to be u16 



[ Upstream commit ffe498237b36ee42624e139b21efa05da4ff1f48 ]

Since the req_speeds field in struct ice_link_status is a u8,
req_speeds & ICE_AQ_LINK_SPEED_40GB always returns 0. This was caught
by a coverity scan.

Fix this by changing req_speeds to be u16.

Reported-by: default avatarBruce Allan <bruce.w.allan@intel.com>
Signed-off-by: default avatarChinh T Cao <chinh.t.cao@intel.com>
Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 86927afb

drivers/net/ethernet/intel/ice/ice_type.h

+1 −1
Original line number Diff line number Diff line
@@ -83,12 +83,12 @@ struct ice_link_status { 
	u64 phy_type_low;

	u16 max_frame_size;

	u16 link_speed;

	u16 req_speeds;

	u8 lse_ena;	/* Link Status Event notification */

	u8 link_info;

	u8 an_info;

	u8 ext_info;

	u8 pacing;

	u8 req_speeds;

	/* Refer to #define from module_type[ICE_MODULE_TYPE_TOTAL_BYTE] of

	 * ice_aqc_get_phy_caps structure

	 */