Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06d7e994 authored by Finn Thain's avatar Finn Thain Committed by Michael Ellerman
Browse files

via-cuda: Remove redundant temporary variable 



There is no possibility that current_req can change during execution of
cuda_start(). This can be confirmed by inspection: cuda_lock is always
held whenever cuda_start() is called or current_req is modified.

Tested-by: default avatarStan Johnson <userm57@yahoo.com>
Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 523717d1

drivers/macintosh/via-cuda.c

+2 −6
Original line number Diff line number Diff line
@@ -414,19 +414,15 @@ cuda_write(struct adb_request *req) 
static void

cuda_start(void)

{

    struct adb_request *req;



    /* assert cuda_state == idle */

    /* get the packet to send */

    req = current_req;

    if (req == 0)

    if (current_req == NULL)

	return;

    if ((in_8(&via[B]) & TREQ) == 0)

	return;			/* a byte is coming in from the CUDA */



    /* set the shift register to shift out and send a byte */

    out_8(&via[ACR], in_8(&via[ACR]) | SR_OUT);

    out_8(&via[SR], req->data[0]);

    out_8(&via[SR], current_req->data[0]);

    out_8(&via[B], in_8(&via[B]) & ~TIP);

    cuda_state = sent_first_byte;

}