Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06d3f2e0 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mauro Carvalho Chehab
Browse files

[media] tc358743: set direction of reset gpio using devm_gpiod_get 



Commit 25614824 ("[media] tc358743: support probe from device tree")
failed to explicitly set the direction of the reset gpio. Use the
optional flag of devm_gpiod_get to make up leeway.

This is also necessary because the flag parameter will become mandatory
soon.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent d071c833

drivers/media/i2c/tc358743.c

+1 −2
Original line number Diff line number Diff line
@@ -1681,7 +1681,6 @@ static const struct v4l2_ctrl_config tc358743_ctrl_audio_present = { 
#ifdef CONFIG_OF

static void tc358743_gpio_reset(struct tc358743_state *state)

{

	gpiod_set_value(state->reset_gpio, 0);

	usleep_range(5000, 10000);

	gpiod_set_value(state->reset_gpio, 1);

	usleep_range(1000, 2000);
@@ -1783,7 +1782,7 @@ static int tc358743_probe_of(struct tc358743_state *state) 
	state->pdata.ths_trailcnt = 0x2;

	state->pdata.hstxvregcnt = 0;



	state->reset_gpio = devm_gpiod_get(dev, "reset");

	state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);

	if (IS_ERR(state->reset_gpio)) {

		dev_err(dev, "failed to get reset gpio\n");

		ret = PTR_ERR(state->reset_gpio);