Commit 06b898ec authored Mar 07, 2016 by Douglas Anderson Committed by Mark Yao Mar 28, 2016

drm/rockchip: dw_hdmi: Don't call platform_set_drvdata()



The Rockchip dw_hdmi driver just called platform_set_drvdata() to get
your hopes up that maybe, somehow, you'd be able to retrieve the 'struct
rockchip_hdmi' from a pointer to the 'struct device'.  You can't.  When
we call dw_hdmi_bind() the main driver calls dev_set_drvdata(), which
clobbers our setting.

Let's just remove the platform_set_drvdata() to avoid dashing people's
hopes.

Signed-off-by: Douglas Anderson <dianders@chromium.org>

parent 328b51c0

drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -271,8 +271,6 @@ static int dw_hdmi_rockchip_bind(struct device dev, struct device master,
		if (!iores)
		return -ENXIO;

		platform_set_drvdata(pdev, hdmi);

		encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node);
		/*
		* If we failed to find the CRTC(s) which this encoder is